[CurrencyService] Add C++ Metrics #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lalitb would you mind taking a look at this one? |
|
Could you open and link a pr to the website docs adding this as a user created metric ? |
2 tasks
Done! |
lalitb
approved these changes
Feb 26, 2023
mviitane
approved these changes
Feb 27, 2023
mic-max
reviewed
Feb 28, 2023
mic-max
approved these changes
Feb 28, 2023
styblope
pushed a commit
to instana/opentelemetry-demo
that referenced
this pull request
Mar 12, 2023
* Add cpp metrics * Add IntCounter to CurrencyService * changelog * changelog * Fix indentantion * Add line break * Remove unnecessary comma * Remove unnecessary includes * Apply suggestions
mat-rumian
pushed a commit
to SumoLogic/opentelemetry-demo
that referenced
this pull request
Mar 20, 2023
* Add cpp metrics * Add IntCounter to CurrencyService * changelog * changelog * Fix indentantion * Add line break * Remove unnecessary comma * Remove unnecessary includes * Apply suggestions
juliangiuca
pushed a commit
to juliangiuca/opentelemetry-demo
that referenced
this pull request
Apr 12, 2023
* Add cpp metrics * Add IntCounter to CurrencyService * changelog * changelog * Fix indentantion * Add line break * Remove unnecessary comma * Remove unnecessary includes * Apply suggestions
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* Add cpp metrics * Add IntCounter to CurrencyService * changelog * changelog * Fix indentantion * Add line break * Remove unnecessary comma * Remove unnecessary includes * Apply suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds the manual metric
app_currency_counterto the currency service.The metric counts how many times a specific currency was converted.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.