Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional Prometheus exporter configuration options #59

Closed
codeboten opened this issue Nov 27, 2023 · 2 comments
Closed

Additional Prometheus exporter configuration options #59

codeboten opened this issue Nov 27, 2023 · 2 comments

Comments

@codeboten
Copy link
Contributor

The Prometheus exporter in Go exposes certain options that are necessary to be able to move forward with supporting configuration in the OpenTelemetry collector. These options are listed here: https://github.com/open-telemetry/opentelemetry-go/blob/main/exporters/prometheus/config.go

The question I have is whether we should add options for these in the config schema.
@codeboten codeboten mentioned this issue Nov 27, 2023
Merged
3 tasks
carlosalberto pushed a commit to open-telemetry/opentelemetry-specification that referenced this issue Dec 13, 2023
add optional configuration for prometheus exporter (#3777)
3d60131 
## Changes

The suffix for types and units can be optionally disabled in Prometheus
exporters. This PR captures these configuration options to allow them to
then be captured by the OpenTelemetry Configuration as well.

* [x] Related issues
open-telemetry/opentelemetry-configuration#59
@codeboten codeboten mentioned this issue Dec 15, 2023
Merged
3 tasks
@jack-berg
Copy link
Member

I know we've made some progress on this.. are there any important prometheus properties which still aren't part of the schema? As of now we have:

  • host
  • port
  • without_units
  • without_type_suffix
  • without_scope_info
  • with_resource_constant_labels

@codeboten
Copy link
Contributor Author

I believe all the necessary options have been added. I'll open follow up issues for any individual configurations if that's not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Declarative Configuration Stability
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codeboten @jack-berg