Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated function IsValid from trace/span ID #2522

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Feb 20, 2021

Updates #2488

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested a review from a team February 20, 2021 22:10
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #2522 (c5d8528) into main (379645d) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2522      +/-   ##
==========================================
+ Coverage   91.71%   91.73%   +0.01%     
==========================================
  Files         265      265              
  Lines       15083    15081       -2     
==========================================
  Hits        13834    13834              
+ Misses        867      865       -2     
  Partials      382      382              
Impacted Files Coverage Δ
consumer/pdata/spanid.go 100.00% <ø> (+16.66%) ⬆️
consumer/pdata/traceid.go 100.00% <ø> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 347cfa9...c5d8528. Read the comment docs.

@bogdandrutu bogdandrutu merged commit d71dd31 into open-telemetry:main Feb 22, 2021
@bogdandrutu bogdandrutu deleted the rmisvalid branch February 22, 2021 20:18
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants