Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move MetricsData to internaldata #2512

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Feb 19, 2021

Fixes #2482

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested a review from a team February 19, 2021 17:29
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #2512 (d94eec1) into main (6ad7d67) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2512   +/-   ##
=======================================
  Coverage   92.02%   92.02%           
=======================================
  Files         271      271           
  Lines       15444    15444           
=======================================
  Hits        14212    14212           
  Misses        850      850           
  Partials      382      382           
Impacted Files Coverage Δ
translator/internaldata/oc_to_metrics.go 91.24% <ø> (ø)
...eceiver/opencensusreceiver/ocmetrics/opencensus.go 92.72% <100.00%> (ø)
...eceiver/prometheusreceiver/internal/transaction.go 90.69% <100.00%> (ø)
translator/internaldata/metrics_to_oc.go 97.83% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ad7d67...d94eec1. Read the comment docs.

@bogdandrutu bogdandrutu force-pushed the rmconsumerdata branch 2 times, most recently from c93ba80 to 0ad48eb Compare February 25, 2021 19:30
@bogdandrutu bogdandrutu changed the title Remove TraceData, move MetricsData to internaldata Move MetricsData to internaldata Feb 25, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit 88d9a16 into open-telemetry:main Mar 2, 2021
@bogdandrutu bogdandrutu deleted the rmconsumerdata branch March 2, 2021 22:26
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove usage of deprecated consumerdata
2 participants