Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sqlserverreceiver detailed sample configuration link doesn't work in README.md #9798

Closed
vipuljain24 opened this issue May 9, 2022 · 9 comments
Assignees
Labels
bug Something isn't working receiver/sqlserver

Comments

@vipuljain24
Copy link

Describe the bug
In directory "opentelemetry-collector-contrib/receiver/sqlserverreceiver/", in README.md file, there is a link to detailed sample configurations. On clicking it, it throws 404 error.

Steps to reproduce
Navigate to "opentelemetry-collector-contrib/receiver/sqlserverreceiver/README.md", and click on the link mentioned in configuration section for detailed sample configurations.

What did you expect to see?
We expect to see how the sql server receiver can be configured to monitor sql server in windows.

What did you see instead?
A 404 error on clicking the link.

What version did you use?
On main branch

What config did you use?
NA

Environment
NA

Additional context
None

@vipuljain24 vipuljain24 added the bug Something isn't working label May 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Nov 8, 2022
@atoulme
Copy link
Contributor

atoulme commented Jan 7, 2023

I can look into this, please assign to me.

@fatsheep9146
Copy link
Contributor

I can look into this, please assign to me.

It's yours. @atoulme

@github-actions
Copy link
Contributor

Pinging code owners for receiver/sqlserver: @djaglowski @StefanKurek. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Mar 14, 2023
@github-actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 26, 2023
@atoulme atoulme reopened this May 26, 2023
@crobert-1
Copy link
Member

crobert-1 commented May 31, 2023

This dead link was introduced with the receiver itself in #9252. The link in question was to a non-existent (at the time) config file. As we can see in the PR, there's a reference to a config file under ./testdata/config.yaml, but the PR didn't include this file.

I believe this issue was resolved by #20265 as it added a sample config file that is now referenced by the README. There are no dead links in the README anymore. I believe we can mark this issue as resolved.

@crobert-1
Copy link
Member

@atoulme or @vipuljain24: If you agree with my last comment, this issue can be closed.

@atoulme
Copy link
Contributor

atoulme commented Jun 8, 2023

Thanks for looking into it. I believe you, let's close this issue and it can be reopened if there is more work required. Thanks again!

@atoulme atoulme closed this as completed Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working receiver/sqlserver
Projects
None yet
Development

No branches or pull requests

4 participants