-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sqlserverreceiver detailed sample configuration link doesn't work in README.md #9798
Comments
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping |
I can look into this, please assign to me. |
It's yours. @atoulme |
Pinging code owners for receiver/sqlserver: @djaglowski @StefanKurek. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
This dead link was introduced with the receiver itself in #9252. The link in question was to a non-existent (at the time) config file. As we can see in the PR, there's a reference to a config file under I believe this issue was resolved by #20265 as it added a sample config file that is now referenced by the README. There are no dead links in the README anymore. I believe we can mark this issue as resolved. |
@atoulme or @vipuljain24: If you agree with my last comment, this issue can be closed. |
Thanks for looking into it. I believe you, let's close this issue and it can be reopened if there is more work required. Thanks again! |
Describe the bug
In directory "opentelemetry-collector-contrib/receiver/sqlserverreceiver/", in README.md file, there is a link to detailed sample configurations. On clicking it, it throws 404 error.
Steps to reproduce
Navigate to "opentelemetry-collector-contrib/receiver/sqlserverreceiver/README.md", and click on the link mentioned in configuration section for detailed sample configurations.
What did you expect to see?
We expect to see how the sql server receiver can be configured to monitor sql server in windows.
What did you see instead?
A 404 error on clicking the link.
What version did you use?
On main branch
What config did you use?
NA
Environment
NA
Additional context
None
The text was updated successfully, but these errors were encountered: