Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/hostmetrics/process_scraper] Rename metadata conflicting with the metrics package name #8815

Closed
dmitryax opened this issue Mar 23, 2022 · 2 comments · Fixed by #8979
Closed

[receiver/hostmetrics/process_scraper] Rename metadata conflicting with the metrics package name #8815

dmitryax opened this issue Mar 23, 2022 · 2 comments · Fixed by #8979
Assignees
@hydeenoble
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dmitryax
Copy link
Member

The local variable name metadata conflicts with the generated package name and makes this less readable.

Originally posted by @djaglowski in #8555 (comment)
@dmitryax dmitryax added help wanted Extra attention is needed good first issue Good for newcomers labels Mar 23, 2022
@dmitryax dmitryax mentioned this issue Mar 23, 2022
Merged
@hydeenoble
Copy link
Contributor

@dmitryax I would like to pick this up if no one is currently working on it.

PS: I am open to ideas for the variable name :)

@dmitryax
Copy link
Member Author

Hi @hydeenoble . Thanks. Picking up a variable name is the biggest part of the work :) feel free to suggest any in your PR.

@hydeenoble hydeenoble mentioned this issue Mar 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hydeenoble hydeenoble

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
2 participants
@dmitryax @hydeenoble