Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server opa should be able to Listen to a Unix Domain Socket #692

Closed
FrankJLhota opened this issue Apr 6, 2018 · 4 comments
Closed

Server opa should be able to Listen to a Unix Domain Socket #692

FrankJLhota opened this issue Apr 6, 2018 · 4 comments

Comments

@FrankJLhota
Copy link

This would be handy for testing, and for instances where opa services multiple local processes.

@tsandall
Copy link
Member

tsandall commented Apr 7, 2018

This question has come up from a few users and while it's not been a blocker, it would be nice to have.

From an implementation point of view, the following changes should be made (minimally):

  • Add an extra listener loop in server.go. The listener should open/create a unix domain socket and then serve the Server on it.

  • Plumb a file path argument for the domain socket through from the cmd package to the server package. See other server parameters for examples.

  • If feasible, add an integration test that starts the server with unix domain socket listener enabled and validates that the HTTP API is served correctly.

@JAORMX
Copy link
Contributor

JAORMX commented May 23, 2018

Addressing this here #752

@JAORMX
Copy link
Contributor

JAORMX commented May 28, 2018

Fixed in #752

Should this be closed?

@tsandall
Copy link
Member

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants