feat(pointcloud): Temporarily hide the trackID

open-mmlab · Sep 19, 2022 · e13d1e3 · e13d1e3
1 parent 618f6ba
commit e13d1e3
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 14 deletions.
diff --git a/packages/lb-annotation/src/core/pointCloud/index.ts b/packages/lb-annotation/src/core/pointCloud/index.ts
@@ -326,11 +326,13 @@ export class PointCloud {
     const cube = new THREE.Mesh(geometry, material);
     const box = new THREE.BoxHelper(cube, color);
     const arrow = this.generateBoxArrow(boxParams);
-    const boxID = this.generateBoxTrackID(boxParams);
+
+    // Temporarily hide
+    // const boxID = this.generateBoxTrackID(boxParams);
+    // group.add(boxID);
 
     group.add(box);
     group.add(arrow);
-    group.add(boxID);
     group.position.set(center.x, center.y, center.z);
 
     group.rotation.set(0, 0, rotation);
@@ -789,6 +791,10 @@ export class PointCloud {
   };
 
   public generateBoxTrackID = (boxParams: IPointCloudBox) => {
+    if (!boxParams.trackID) {
+      return;
+    }
+
     const texture = new THREE.Texture(this.getTextCanvas(boxParams.trackID.toString()));
     texture.needsUpdate = true;
     const sprite = new THREE.SpriteMaterial({ map: texture, depthWrite: false });

diff --git a/packages/lb-components/src/components/pointCloudView/hooks/usePointCloudViews.ts b/packages/lb-components/src/components/pointCloudView/hooks/usePointCloudViews.ts
@@ -324,14 +324,15 @@ export const usePointCloudViews = () => {
 
   const { pointCloudInstance: topViewPointCloud } = topViewInstance;
 
-  const getNextTrackID = () => {
-    if (pointCloudBoxList.length > 0) {
-      const sortedPcList = pointCloudBoxList.sort((a, b) => a.trackID - b.trackID);
-      return sortedPcList.slice(-1)[0]?.trackID + 1;
-    }
+  // Temporarily hide
+  // const getNextTrackID = () => {
+  //   if (pointCloudBoxList.length > 0) {
+  //     const sortedPcList = pointCloudBoxList.sort((a, b) => a.trackID - b.trackID);
+  //     return sortedPcList.slice(-1)[0]?.trackID + 1;
+  //   }
 
-    return 1;
-  };
+  //   return 1;
+  // };
 
   const mainViewGenBox = (boxParams: IPointCloudBox) => {
     mainViewInstance?.generateBox(boxParams);
@@ -346,9 +347,11 @@ export const usePointCloudViews = () => {
     });
     const polygonOperation = topViewInstance?.pointCloud2dOperation;
 
-    const boxParams: IPointCloudBox = Object.assign(newParams, {
-      trackID: getNextTrackID(),
-    });
+    // Temporarily hide
+    // const boxParams: IPointCloudBox = Object.assign(newParams, {
+    //   trackID: getNextTrackID(),
+    // });
+    const boxParams: IPointCloudBox = newParams;
 
     polygonOperation.setSelectedIDs([newPolygon.id]);
     setSelectedIDs(boxParams.id);

diff --git a/packages/lb-components/src/views/MainView/sidebar/ToolIcons.tsx b/packages/lb-components/src/views/MainView/sidebar/ToolIcons.tsx
@@ -44,7 +44,7 @@ const toolList = [
   },
 ];
 
-const getToolNameVersion = (lang: 'en' | 'cn') => {
+const getToolNameVersion = (lang: string) => {
   if (lang === 'en') {
     return TOOL_NAME_EN;
   }

diff --git a/packages/lb-utils/src/types/pointCloud.ts b/packages/lb-utils/src/types/pointCloud.ts
@@ -76,8 +76,8 @@ export interface IPointCloudBox extends IVolume {
   center: I3DSpaceCoord;
   id: string;
   rotation: number;
-  trackID: number;
   valid: boolean;
+  trackID?: number; // It can be deleted.
   subAttribute?: {
     [k: string]: string;
   };