fix(pointcloud): Init hideAttr while imgIndex changed

open-mmlab · Mar 22, 2023 · 99e5642 · 99e5642
1 parent d26691e
commit 99e5642
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/packages/lb-annotation/src/core/pointCloud/index.ts b/packages/lb-annotation/src/core/pointCloud/index.ts
@@ -442,8 +442,9 @@ export class PointCloud {
     }
 
     if (camera) {
-      const cameraTar = this.getOrthographicCameraTarget(camera as OrthographicCamera);
-      this.updateCamera(camera.position, cameraTar);
+      const cameraTarget = this.getOrthographicCameraTarget(camera as OrthographicCamera);
+      this.camera.zoom = camera.zoom;
+      this.updateCamera(camera.position, cameraTarget);
     }
   };
 

diff --git a/packages/lb-components/src/components/pointCloudView/PointCloud3DView.tsx b/packages/lb-components/src/components/pointCloudView/PointCloud3DView.tsx
@@ -191,7 +191,7 @@ const PointCloud3D: React.FC<IA2MapStateProps> = ({ currentData, config }) => {
 
   const ptCloud3DCtx = useMemo(() => {
     return { reset3DView, setTarget3DView, isActive: !!selectedBox, followTopView };
-  }, [selectedBox]);
+  }, [selectedBox, ptCtx.mainViewInstance]);
 
   const PointCloud3DTitle = (
     <div>

diff --git a/packages/lb-components/src/components/pointCloudView/PointCloudContext.tsx b/packages/lb-components/src/components/pointCloudView/PointCloudContext.tsx
@@ -42,6 +42,7 @@ export interface IPointCloudContext extends IPointCloudContextInstances {
 
   history: ActionsHistory; // Operation History
   hideAttributes: string[];
+  setHideAttributes: (hideAttrs: string[]) => void;
   toggleAttributesVisible: (attribute: string) => void;
   reRender: (_displayPointCloudList: IPointCloudBoxList, _polygonList: IPolygonData[]) => void;
   attrPanelLayout: AttrPanelLayout;
@@ -81,6 +82,7 @@ export const PointCloudContext = React.createContext<IPointCloudContext>({
   setZoom: () => {},
   history: new ActionsHistory(),
   hideAttributes: [],
+  setHideAttributes: () => {},
   toggleAttributesVisible: () => {},
   reRender: () => {},
   setAttrPanelLayout: () => {},

diff --git a/packages/lb-components/src/components/pointCloudView/PointCloudListener.tsx b/packages/lb-components/src/components/pointCloudView/PointCloudListener.tsx
@@ -241,6 +241,10 @@ const PointCloudListener: React.FC<IProps> = ({
     updatePointCloudData?.();
   }, [imgIndex, ptCtx.mainViewInstance]);
 
+  useEffect(() => {
+    ptCtx.setHideAttributes([]);
+  }, [imgIndex]);
+
   // Update the listener of toolInstance.
   useEffect(() => {
     toolInstanceRef.current.exportData = () => {