Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a React dropdown out of the choose form variable-dropdown #4524

Open
joeribekker opened this issue Jul 15, 2024 · 0 comments · May be fixed by #4675 or #4730
Open

Make a React dropdown out of the choose form variable-dropdown #4524

joeribekker opened this issue Jul 15, 2024 · 0 comments · May be fixed by #4675 or #4730
Assignees
@robinmolen
Labels
enhancement owner: maykin
Milestone
Release 3.0

Comments

@joeribekker
Copy link
Contributor

Thema / Theme

Frontend

Omschrijving / Description

Separated from #4519

Added value / Toegevoegde waarde

No response

Aanvullende opmerkingen / Additional context

No response
@joeribekker joeribekker added triage Issue needs to be validated. Remove this label if the issue considered valid. enhancement and removed triage Issue needs to be validated. Remove this label if the issue considered valid. labels Jul 15, 2024
@joeribekker joeribekker added this to the Release 2.8.0 milestone Jul 15, 2024
robinmolen added a commit that referenced this issue Sep 17, 2024
@robinmolen
✨ [#4524] added react-select to the VariableSelection
3806732
robinmolen added a commit that referenced this issue Sep 17, 2024
@robinmolen
💄 [#4524] minimum width for form-variable-dropdown
dec1a38
@robinmolen robinmolen linked a pull request Sep 17, 2024 that will close this issue
Open
9 tasks
robinmolen added a commit that referenced this issue Sep 17, 2024
@robinmolen
💄 [#4524] prettier code styling
3753222
robinmolen added a commit that referenced this issue Sep 17, 2024
@robinmolen
📝 [#4524] Marked SelectWithoutFormik as deprecated
38747e8
robinmolen added a commit that referenced this issue Sep 17, 2024
@robinmolen
[#4524] Using classNames function for dynamic classes
59a60d2
robinmolen added a commit that referenced this issue Sep 17, 2024
@robinmolen
🩹 [#4524] Ensure that react-select is presented above the form save b…
a88b6f1 
…uttons
robinmolen added a commit that referenced this issue Sep 17, 2024
@robinmolen
✨ [#4524] VariableSelection grouped by source
9e734e8
robinmolen added a commit that referenced this issue Sep 17, 2024
@robinmolen
💄 [#4524] Styled VariableSelection options
f67b704
robinmolen added a commit that referenced this issue Sep 17, 2024
@robinmolen
🎨 [#4524] Prettier code styling
35c84e3
robinmolen added a commit that referenced this issue Sep 17, 2024
@robinmolen
🩹 [#4524] Replaced hard-coded values with constants
adb36ce
robinmolen added a commit that referenced this issue Sep 17, 2024
@robinmolen
📝 [#4524] Updated VariableSelection.stories.js
d93df72 
Added sources and formDefinitions. This allows for the testing of the new VariableSelection react-select grouping
robinmolen added a commit that referenced this issue Sep 18, 2024
@robinmolen
🔥 [#4524] Removed unused storybook config
9130f0a
robinmolen added a commit that referenced this issue Sep 18, 2024
@robinmolen
✅ [#4524] Fixed storybook tests
986cd4c
robinmolen added a commit that referenced this issue Sep 18, 2024
@robinmolen
🎨 [#4524] Prettier code styling
cc207fe
robinmolen added a commit that referenced this issue Sep 18, 2024
@robinmolen
✅ [#4524] Fixing e2e tests
ddd8d76
robinmolen added a commit that referenced this issue Sep 18, 2024
@robinmolen
🎨 [#4524] Python code styling
714b630
sergei-maertens pushed a commit that referenced this issue Sep 19, 2024
@robinmolen @sergei-maertens
✨ [#4524] added react-select to the VariableSelection
e1e7535
sergei-maertens pushed a commit that referenced this issue Sep 19, 2024
@robinmolen @sergei-maertens
💄 [#4524] minimum width for form-variable-dropdown
1ea8dd8
sergei-maertens pushed a commit that referenced this issue Sep 19, 2024
@robinmolen @sergei-maertens
💄 [#4524] prettier code styling
ea0c0e3
sergei-maertens pushed a commit that referenced this issue Sep 19, 2024
@robinmolen @sergei-maertens
[#4524] Using classNames function for dynamic classes
c02cba4
sergei-maertens pushed a commit that referenced this issue Sep 19, 2024
@robinmolen @sergei-maertens
🩹 [#4524] Ensure that react-select is presented above the form save b…
59b1673 
…uttons
sergei-maertens pushed a commit that referenced this issue Sep 19, 2024
@robinmolen @sergei-maertens
✨ [#4524] VariableSelection grouped by source
198e4c7
sergei-maertens pushed a commit that referenced this issue Sep 19, 2024
@robinmolen @sergei-maertens
💄 [#4524] Styled VariableSelection options
ebee697
sergei-maertens pushed a commit that referenced this issue Sep 19, 2024
@robinmolen @sergei-maertens
🎨 [#4524] Prettier code styling
be01823
sergei-maertens pushed a commit that referenced this issue Sep 19, 2024
@robinmolen @sergei-maertens
🩹 [#4524] Replaced hard-coded values with constants
6e8f39e
sergei-maertens pushed a commit that referenced this issue Sep 19, 2024
@robinmolen @sergei-maertens
📝 [#4524] Updated VariableSelection.stories.js
c1d77a4 
Added sources and formDefinitions. This allows for the testing of the new VariableSelection react-select grouping
sergei-maertens pushed a commit that referenced this issue Sep 19, 2024
@robinmolen @sergei-maertens
🔥 [#4524] Removed unused storybook config
d8465c8
sergei-maertens pushed a commit that referenced this issue Sep 19, 2024
@robinmolen @sergei-maertens
✅ [#4524] Fixed storybook tests
e80b432
sergei-maertens pushed a commit that referenced this issue Sep 19, 2024
@robinmolen @sergei-maertens
🎨 [#4524] Prettier code styling
b5cccfe
sergei-maertens pushed a commit that referenced this issue Sep 19, 2024
@robinmolen @sergei-maertens
✅ [#4524] Fixing e2e tests
e93d6bc
sergei-maertens pushed a commit that referenced this issue Sep 19, 2024
@robinmolen @sergei-maertens
🎨 [#4524] Python code styling
7519e29
robinmolen added a commit that referenced this issue Sep 25, 2024
@robinmolen
💄 [#4524] Removed magic z-index from tinymce and submit-row
daa0d1a
robinmolen added a commit that referenced this issue Sep 25, 2024
@robinmolen
✨ [#4524] Using react-select for the VariableSelection
ba87f95 
Marked SelectWithoutFormik as deprecated
robinmolen added a commit that referenced this issue Sep 25, 2024
@robinmolen
✨ [#4524] VariableSelection grouped by source
0747766
robinmolen added a commit that referenced this issue Sep 25, 2024
@robinmolen
✅ [#4524] Updated VariableSelection.stories.js
4580651 
Added sources and formDefinitions. This allows for the testing of the new VariableSelection react-select grouping
robinmolen added a commit that referenced this issue Sep 25, 2024
@robinmolen
✅ [#4524] Fixed storybook tests
190c9f6
robinmolen added a commit that referenced this issue Sep 25, 2024
@robinmolen
✅ [#4524] Fixing e2e tests
dfad373
robinmolen added a commit that referenced this issue Sep 25, 2024
@robinmolen
💄 [#4524] Removed magic z-index from tinymce and submit-row
b84481b
robinmolen added a commit that referenced this issue Oct 2, 2024
@robinmolen
✨ [#4524] Using react-select for the VariableSelection
385e481 
Marked SelectWithoutFormik as deprecated
robinmolen added a commit that referenced this issue Oct 2, 2024
@robinmolen
✨ [#4524] VariableSelection grouped by source
31c7f1d
robinmolen added a commit that referenced this issue Oct 2, 2024
@robinmolen
✅ [#4524] Updated VariableSelection.stories.js
fa5166f 
Added sources and formDefinitions. This allows for the testing of the new VariableSelection react-select grouping
robinmolen added a commit that referenced this issue Oct 2, 2024
@robinmolen
✅ [#4524] Fixed storybook tests
994e06e
robinmolen added a commit that referenced this issue Oct 2, 2024
@robinmolen
✅ [#4524] Fixing e2e tests
522b3c7
robinmolen added a commit that referenced this issue Oct 2, 2024
@robinmolen
💄 [#4524] Removed magic z-index from tinymce and submit-row
7de32f6
sergei-maertens pushed a commit that referenced this issue Oct 3, 2024
@robinmolen @sergei-maertens
✨ [#4524] Using react-select for the VariableSelection
59da2b3 
Marked SelectWithoutFormik as deprecated
sergei-maertens pushed a commit that referenced this issue Oct 3, 2024
@robinmolen @sergei-maertens
✅ [#4524] Updated variable select stories
11fc6ed 
Added sources and formDefinitions. This allows for the testing of the new VariableSelection react-select grouping

+ fixed the stories broken by the switch to react-select
sergei-maertens pushed a commit that referenced this issue Oct 3, 2024
@robinmolen @sergei-maertens
✅ [#4524] Fixing e2e tests
00157fd
sergei-maertens pushed a commit that referenced this issue Oct 3, 2024
@robinmolen @sergei-maertens
💄 [#4524] Removed magic z-index from tinymce and submit-row
c611cef
@sergei-maertens sergei-maertens linked a pull request Oct 3, 2024 that will close this issue
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robinmolen robinmolen

Labels
enhancement owner: maykin
Projects
Development
Status: Implemented
Milestone
Release 3.0
3 participants
@joeribekker @sergei-maertens @robinmolen