-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Hyperparameter tuning Workflow Template #786
Conversation
db/go/util.go
Outdated
Labels: labels, | ||
} | ||
|
||
err = ReplaceArtifactRepositoryType(client, namespace, workflowTemplate, nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rushtehrani Let's use ReplaceRuntimeVariablesInManifest
, ReplaceArtifactRepositoryType
does not do select.nodepool
hyperparameterTuningTemplateName, | ||
map[string]string{ | ||
"framework": "pytorch", | ||
"tuner": "TPE", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rushtehrani Should we add "created-by": "system" ?
What this PR does:
Which issue(s) this PR fixes:
Fixes onepanelio/core#
Special notes for your reviewer:
Checklist
Please check if applies
Required