add Destination validation for ruby-saml/response #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this change adds validation for Destination attribute which is optionally included in the SAML response. - response method to return Destination attribute via REXML - response method to validate the destination against consumer service URL available in settings. - unit tests. note that @pitbulk originally implemented these changes in #197; however, this specific validation didn't make it to master branch (or >= 1.0.0). i am hoping this will resolve #301.
|
Thanks for the contribution. |
pitbulk
added a commit
that referenced
this pull request
Feb 11, 2016
…aml-response add Destination validation for ruby-saml/response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Migrations
NO
Description
this change adds validation for
Destinationattribute which is optionally included in the SAML response.Destinationattribute viaREXML.note that @pitbulk originally implemented these changes in #197; however, this specific validation didn't make it to master branch (or >= 1.0.0). i merely duplicated his work and matched the new validation pattern (no
soft) inmaster.if accepted, this would fix #301.
Related PRs
response_validationsimprove_validationsTodos
README.Deploy Notes
no migrations or breaking changes; some IdPs may not send the right
Destinationdue to configuration issues – since it's an optional value, when provided, expectation is that it must be valid. to keep those integrations working,#consumeaction be tweaked to ignore validations forDestinationattribute.Steps to Test or Reproduce
N/A
Impacted Areas in Application
List general components of the application that this PR will affect: