Add ability to sign metadata. (Improved) #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into Umofomia-sign-metadata
…int optional on metadata generator, signature position fixed). Fix algorithm calculator
|
@Lordnibbler, @luisvm what do you think about this PR? |
| end | ||
|
|
||
| it "creates a signed metadata" do | ||
| assert_match %r[<ds:SignatureValue>\s*([a-zA-Z0-9/+=]+)\s*</ds:SignatureValue>]m, xml_text |
There was a problem hiding this comment.
FYI, I originally added the two \s* in the regular expression and the m at the end of it to take into account the fact that the metadata was being pretty-printed. Now that you took out the pretty-printing for the test, these should no longer be needed.
pitbulk
added a commit
that referenced
this pull request
Mar 25, 2015
| xml_text = OneLogin::RubySaml::Metadata.new.generate(settings, true) | ||
| # assert correct xml declaration | ||
| start = "<?xml version='1.0' encoding='UTF-8'?>\n<md:EntityDescriptor" | ||
| assert xml_text[0..start.length-1] == start |
There was a problem hiding this comment.
probably good to use assert_equal here to be consistent
|
comments aside looks good 👍 |
pitbulk
added a commit
that referenced
this pull request
Mar 26, 2015
Add ability to sign metadata. (Improved)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #207.
Improved:
Fix algorithm calculator. This method was wrong