Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow requirement of single files #205

Merged
merged 4 commits into from
Mar 18, 2015
Merged

Allow requirement of single files #205

merged 4 commits into from
Mar 18, 2015

Conversation

rafaelgonzalez
Copy link
Contributor

This is to reflect the advertised behaviour in the README.

You can manually test requirements of each file in irb (exiting irb between each) with:

  • require_relative 'lib/onelogin/ruby-saml/authrequest'
  • require_relative 'lib/onelogin/ruby-saml/logoutrequest'
  • require_relative 'lib/onelogin/ruby-saml/logoutresponse'
  • require_relative 'lib/onelogin/ruby-saml/settings'
  • require_relative 'lib/onelogin/ruby-saml/slo_logoutrequest'
  • require_relative 'lib/onelogin/ruby-saml/slo_logoutresponse'

@pitbulk
Copy link
Collaborator

pitbulk commented Mar 17, 2015

👍

@pitbulk
Copy link
Collaborator

pitbulk commented Mar 18, 2015

@luisvm , @Lordnibbler what do you think?

@cthornton
Copy link
Contributor

👍

2 similar comments
@luisvm
Copy link
Contributor

luisvm commented Mar 18, 2015

👍

@Lordnibbler
Copy link
Contributor

👍

Lordnibbler added a commit that referenced this pull request Mar 18, 2015
@Lordnibbler Lordnibbler merged commit d136471 into SAML-Toolkits:master Mar 18, 2015
@Lordnibbler
Copy link
Contributor

thank you @rafaelgonzalez !

@rafaelgonzalez rafaelgonzalez deleted the fix-single-file-requirements branch March 18, 2015 21:51
@rafaelgonzalez
Copy link
Contributor Author

Cheers everyone

@pitbulk
Copy link
Collaborator

pitbulk commented Mar 20, 2015

The file onelogin.rb is unnecessary since we don't use any
require 'onelogin' anywhere.

I noticed that in ruby-saml-example we never used

require 'onelogin/ruby-saml'

with the gem installed, it imports the lib/ruby-saml.rb so the library is available.

After read the REQUIRING CODE section of rubygem I saw that is common to set in the lib path a file with the name of the library, so I will replace lib/onelogin.rb by lib/ruby-saml.rb .That will maintain ruby-saml-example compatibility.

@Lordnibbler, are you agree?

phlipper added a commit to 01Click/ruby-saml that referenced this pull request Mar 24, 2015
* SAML-Toolkits#205 introduced a regression when the entry point file was
  renamed: `lib/ruby-saml.rb → lib/onelogin/ruby-saml.rb`.
  this is causing problems with `bundler`, and also when
  integrating with other libraries such as `omniauth-saml`.
phlipper added a commit to 01Click/ruby-saml that referenced this pull request Mar 24, 2015
* SAML-Toolkits#205 introduced a regression when the entry point file was
  renamed: `lib/ruby-saml.rb → lib/onelogin/ruby-saml.rb`.
  this is causing problems with `bundler`, and also when
  integrating with other libraries such as `omniauth-saml`.
@Umofomia Umofomia mentioned this pull request Apr 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants