Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metadata validation errors #243

Merged
merged 3 commits into from
Jun 29, 2015

Conversation

soupmatt
Copy link
Contributor

There are xml schema validation errors with the service provider metadata xml that is generated by OneLogin::RubySaml::Metadata#generate. The first is that SingleLogoutService isn't allowed to to have isDefault and index attributes. The other is that the AttributeValue element comes from the assertion schema, not the metadata schema. See the diff for the details.

I also added code that validates the xml produced by each test against the schema.

@pitbulk
Copy link
Collaborator

pitbulk commented Jun 29, 2015

You are right, SingleLogoutService is EndpointType not IndexedEndpointType, so no isDefault / index allowed.

Thanks for contributing that

@Lordnibbler
Copy link
Contributor

seems sane 👍

pitbulk added a commit that referenced this pull request Jun 29, 2015
@pitbulk pitbulk merged commit 02ae8ff into SAML-Toolkits:master Jun 29, 2015
ylansegal added a commit to ylansegal/ruby-saml that referenced this pull request Aug 11, 2015
…port_0.9_rebase

* upstream/master: (47 commits)
  Handle empty URI references as per http://www.w3.org/TR/xmldsig-core/#sec-Same-Document; thx to @sixto for resolving a test case failure.
  support nameid in attribute values
  first attempt at adding support for scoped attributes needs additional work and tests
  Add some documentation about the soft setting parameter
  Update readme.md for 1.0.0 release
  Update date of the 1.0.0 release
  Update Readme and changelog
  Security improvement: Avoid entity expansion (XEE attacks)
  According to the xsd, the issuer has to be before the status
  Update changelog
  Fix SAML-Toolkits#244, related to PR SAML-Toolkits#243. Fix bug on metadata. Reorder KeyDescriptors
  Add logging information to README
  Allow logging to be delegated to an arbitrary Logger.
  Add tests for existing Logging functionality
  no more silent failure fetching idp metadata
  fix schema validation errors in service provider metadata
  tests to validate service provider metadata xml against the schema
  ignore gemfile.lock files in the gemfiles directory
  Prepare 1.0.0 release
  Improve compatibility with namespaces
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants