Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT2 item incorrect data #5950

Open
nwjgit opened this issue Jul 12, 2024 · 2 comments · May be fixed by #5953
Open

DT2 item incorrect data #5950

nwjgit opened this issue Jul 12, 2024 · 2 comments · May be fixed by #5953
Labels
Type: Bug Something isn't working

Comments

@nwjgit
Copy link
Contributor

nwjgit commented Jul 12, 2024

🐛 Bug Report

6b02a88 introduced item switches which switched the dt2 rings from beta id to the proper id but the price and associated wiki page seem to use the beta id information.

  • before:
    Discord_jluJI2sbdl

  • after:
    Discord_XVLAK1AOSv

  • Another issue is we can still create the beta versions of these items. as seen below. I think adding the beta ids to the USELESS_ITEMS in items.ts in OSJS would probably fix the issues.
    Discord_Nf2U30d87P

other issues:

  • /gear stats gear_setup: Venator ring shows the beta icon and not the current icon
  • Soulreaper axe still using the incorrect id

Follow up to: #5284

@nwjgit nwjgit added the Type: Bug Something isn't working label Jul 12, 2024
@gc
Copy link
Collaborator

gc commented Jul 13, 2024

The IDs have not changed. The beta versions now just match the data of the real ones. Removing the beta IDs would (same as before) require all the existing items to be migrated to the new one, which is a pain to do.

@nwjgit
Copy link
Contributor Author

nwjgit commented Jul 13, 2024

The IDs have not changed. The beta versions now just match the data of the real ones. Removing the beta IDs would (same as before) require all the existing items to be migrated to the new one, which is a pain to do.

It's a pain to do but its probably the only real solution. The one currently implemented isn't doing the trick as seen in the original post. i'm not 100% sure how you handled the blood vial fix but I would imagine its the exact same process to remove and migrate the ids and prevent future creation of the wrong id item.

@nwjgit nwjgit linked a pull request Jul 14, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants