Unchecked _max_tb causing TypeError: '<=' not supported between instances of 'int' and 'nonetype'

[GPhilo]

There seems to be a missing check in this line causing a TypeError inside log_failure.

Shouldn't this be checking for _max_tb as well before the <=, like:

if (_max_tb is None) or (_num_failures <= _max_tb):
# rest of code

[okken]

Nice catch. It seems like it, looking at the code, since _max_tb defaults to None in this file.
However, in use, it is always set.
I can't come up with a use case to make this fail line raise an exception as is.

I think the fix may be to set the default value to 1 instead of None, since it more matches the current implementation.
Thanks for reviewing the code.

[GPhilo]

Haha, I don't know if I'm using the code in an unexpected way then, but for me that was still initialized to None and causing issues 😄

[okken]

Do you have a toy example that causes the failure?

[okken]

I'll fix it, but I'd like to have a way to reproduce the problem

[GPhilo]

I'm going on holiday tomorrow for a week, but once I'm back home I'll try to come up with some code to reproduce the issue (just so you know why my next comment will take a while).

[okken]

I've got a fix, I'll push in place soon

[okken]

Fixed with 2.2.2