Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use oclif/table #763

Merged
merged 6 commits into from
Oct 4, 2024
Merged

feat: use oclif/table #763

merged 6 commits into from
Oct 4, 2024

Conversation

mdonnalley
Copy link
Contributor

Use new @oclif/table

@W-16736216@

@iowillhoit
Copy link
Contributor

iowillhoit commented Oct 4, 2024

Again, I think that vertical-with-outline looks a little nicer but it is not as messy with this table.

This command did uncover a bug with oclif/table though. The plugins link command does not have a summary only a multi-line description that uses back-ticks to format newlines. This causes the truncation to be miscalculated.

plugins install                    Installs a plugin into sf.
plugins link                       Links a plugin into the CLI for development.
                                  Installation of a linked plugin will override a user-installed or core plugin.

                                  e.g. I…
plugins remove                     Removes a plugin from the CLI.

It is more obvious when using the vertical dividers:

│ plugins install                  │ Installs a plugin into sf.                                                                                                           │
│ plugins link                     │ Links a plugin into the CLI for development.                                 │
│                                  │Installation of a linked plugin will override a user-installed or core plugin.│
│                                  │                                                                              │
│                                  │e.g. I…                                                                       │
│ plugins remove                   │ Removes a plugin from the CLI.                                                                                                       │

Here is a PR to add the summary oclif/plugin-plugins#980

@iowillhoit iowillhoit merged commit 27c0ebc into main Oct 4, 2024
11 checks passed
@iowillhoit iowillhoit deleted the mdonnalley/table branch October 4, 2024 19:37
iowillhoit added a commit that referenced this pull request Oct 4, 2024
This was referenced Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants