fix: filter undefined static properties to support @oclif/core using ES2022 #496
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commands --json
will break once@oclif/core
uses ES2022, since undefined static properties on theCommand
prototype will be returned byObject.getPrototypeOf
. In order to prevent these undefined properties (likeid
) from overwriting the actual values on theCommand
instance, we need to filter out the undefined properties first.