Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter undefined static properties to support @oclif/core using ES2022 #496

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

mdonnalley
Copy link
Contributor

@mdonnalley mdonnalley commented Sep 22, 2023

commands --json will break once @oclif/core uses ES2022, since undefined static properties on the Command prototype will be returned by Object.getPrototypeOf. In order to prevent these undefined properties (like id) from overwriting the actual values on the Command instance, we need to filter out the undefined properties first.

@cristiand391 cristiand391 merged commit e7e4381 into main Sep 22, 2023
8 checks passed
@cristiand391 cristiand391 deleted the mdonnalley/core-es2022-compability branch September 22, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants