Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fungible Token Standard #44

Closed
garwalsh opened this issue Jan 30, 2024 · 3 comments
Closed

Fungible Token Standard #44

garwalsh opened this issue Jan 30, 2024 · 3 comments
Assignees

Comments

@garwalsh
Copy link
Collaborator

Will build on: https://forums.minaprotocol.com/t/draft-fungible-token-standard-zkapps/6142

In light of the work to generalise the base token here:
https://app.zenhub.com/workspaces/sdk-6130fedb3b0fc600123d8796/issues/gh/o1-labs/o1js/1274

@mitschabaude
Copy link
Member

mitschabaude commented Feb 13, 2024

PR that implements and describes new TokenContract API: o1-labs/o1js#1384

IMO the Approvable and Transferable interfaces, proposed for the token standard here should be changed to exactly match the new TokenContract

Here I proposed that we remove the Callback API, which is done by now: o1-labs/o1js#1402
So the token standard should also no longer rely on that API, but on what the TokenContract does: accepting an AccountUpdateForest which contains all the account updates that it has to approve, in one structure

I don't have strong opinions on some of the "viewable" APIs in the standard

I don't think the Pausable API proposed there is needed.

@mitschabaude
Copy link
Member

mitschabaude commented Feb 13, 2024

I think it would also be nice if the token standard RFC could demonstrate that the proposed token standard is sufficient to cover all important token use cases.

I've written up an analysis of a tricky use case, a DEX which allows smart contracts to interact with it, here: https://o1-labs.slack.com/archives/C062EFYE2D7/p1706872456552659
The conclusion of that thread it's that it's somewhat hard to implement the DEX use case, but possible using offchain state, and even easier if the account update limit was raised

@Trivo25
Copy link
Member

Trivo25 commented May 28, 2024

@Trivo25 Trivo25 closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants