expose hash to group #887
Merged
expose hash to group #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbonichon
approved these changes
May 3, 2023
src/lib/hash.ts
Outdated
Comment on lines
60
to
61
| // r is the second root of sqrt(y^2) | ||
| let r = y.mul(-1); |
There was a problem hiding this comment.
Could we factor that computation, albeit not costly with the let y_ = y.mul(-1) below?
mitschabaude
reviewed
May 3, 2023
There was a problem hiding this comment.
just realized I never finish my review 😓 can you address this @Trivo25
…labs/snarkyjs into feature/hashToCurve-bindings
mitschabaude
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exposes hashToGroup to SnarkJS
closes #772 companion of o1-labs/o1js-bindings#5