-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add nullifier to snarkyjs and mina-signer #882
Conversation
…to feature/nullifier
… into feature/nullifier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, I have a few comment left. The nullifier verification checks out for me now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Do you mind making some changes to the doc comments in nullifier.ts
?
Could you include a short summary of the paper in the class declaration comment? I think even something like this would be incredibly helpful (which is taken directly from the abstract):
Nullifiers are used as a public commitment to a specific anonymous account, to forbid actions like double spending, or allow a consistent identity between anonymous actions.
Could you also include an @example
section in each method? I think it'd be really helpful to see these in your intellisense as you're exploring the API to give some hints to a developer. This will also really help our API reference.
implements the
Nullifier
as a new primitive in both mina-signer and SnarkyJS (in-snark variant) and demonstrates its usage insrc/examples/nullifier.ts
see https://eprint.iacr.org/2022/1255.pdf
bindings o1-labs/o1js-bindings#10
closes #816
RFC: #756