Feature/set timing permission #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
triggered manual workflow run: https://github.com/o1-labs/snarkyjs/actions/runs/3891134963 |
|
actually this is probably missing |
mitschabaude
approved these changes
Jan 11, 2023
| @@ -245,6 +246,7 @@ let Permissions = { | |||
| setTokenSymbol: Permission.signature(), | |||
| incrementNonce: Permission.signature(), | |||
| setVotingFor: Permission.signature(), | |||
| setTiming: Permission.signature(), | |||
There was a problem hiding this comment.
These are the permissions that get applied by default when you deploy a zkApp. I think to prevent the "malicious zkApp developer" case that you outlined, the default for setTiming should be "proof". Note: we changed the default for send to "proof" as well on main, even though here it's still "signature"
…even-more-annoying-changes
…setTiming-permission
This does raise the obvious question about why there's hard-coded JSON..
…n-more-annoying-changes
…setTiming-permission
mrmr1993
force-pushed
the
feature/setTiming-permission
branch
from
9233f73
to
3863a78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.