Use IndexedMerkleMap for OffchainState #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-with-indexed-map
…te-with-indexed-map
…te-with-indexed-map
mitschabaude
commented
Jun 4, 2024
| accounts: OffchainState.Map(PublicKey, UInt64), | ||
| totalSupply: OffchainState.Field(UInt64), | ||
| }, | ||
| { logTotalCapacity: 10, maxActionsPerProof: 5 } |
There was a problem hiding this comment.
we change the defaults, mainly to check that this works and to exercise the case that settling needs multiple proofs
| @state(OffchainStateCommitments) offchainState = State( | ||
| OffchainStateCommitments.empty() | ||
| ); | ||
| @state(OffchainState.Commitments) offchainState = offchainState.commitments(); |
There was a problem hiding this comment.
this looks a bit nicer now, and was necessary because the empty state now depends on the tree size which is part of the offchain state config
Trivo25
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows #1666 and #1671 and uses the new
IndexedMerkleMapforOffchainState.Also:
Fixes(cherry-picked in previous PR)IndexedMerkleMap.clone()IndexedMerkleMap.{overwrite, overwriteIf}TODO: