Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Merkle map keys #1559

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Fix Merkle map keys #1559

merged 4 commits into from
Apr 11, 2024

Conversation

mitschabaude
Copy link
Member

@mitschabaude mitschabaude commented Apr 10, 2024

fixes #1552

the issue was a bit subtle - the previous code assumed that field.toBits() returned 255 bits, which it no longer does

@dfstio
Copy link

dfstio commented Apr 10, 2024

Thank you!

@mitschabaude mitschabaude merged commit e55dd52 into main Apr 11, 2024
12 checks passed
@mitschabaude mitschabaude deleted the fix/merkle-map-key branch April 11, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MerkleMapWitness.computeRootAndKey gives wrong key in o1js 0.18.0
3 participants