Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove children from AccountUpdate: RFC and Implementation #1402

Merged
merged 74 commits into from
Feb 13, 2024
Merged

Remove children from AccountUpdate: RFC and Implementation #1402

merged 74 commits into from
Feb 13, 2024

Commits on Feb 2, 2024

  1. normalize comment

    @mitschabaude
    mitschabaude committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    bc68700 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/token-contract' into refactor/account-update-trees

    @mitschabaude
    mitschabaude committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    e42f0d4 View commit details
    Browse the repository at this point in the history

  3. switch over how we hash calls in the circuit

    @mitschabaude
    mitschabaude committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    2c52e8b View commit details
    Browse the repository at this point in the history

  4. add hint to problem

    @mitschabaude
    mitschabaude committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    40ed27a View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Merge branch 'feature/token-contract' into refactor/account-update-trees

    @mitschabaude
    mitschabaude committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    82d34c3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/token-contract' into refactor/account-update-trees

    @mitschabaude
    mitschabaude committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    e344a31 View commit details
    Browse the repository at this point in the history

  3. fixup not updating unfinished forest

    @mitschabaude
    mitschabaude committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    9a032fc View commit details
    Browse the repository at this point in the history

  4. adapt token contract to new hashing

    @mitschabaude
    mitschabaude committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    af6956e View commit details
    Browse the repository at this point in the history

  5. add more unfinished forest helpers

    @mitschabaude
    mitschabaude committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    755e749 View commit details
    Browse the repository at this point in the history

  6. fix adaptation of token contract

    @mitschabaude
    mitschabaude committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    ba29379 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'feature/token-contract' into refactor/account-update-trees

    @mitschabaude
    mitschabaude committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    5f2f2d7 View commit details
    Browse the repository at this point in the history

  8. minor

    @mitschabaude
    mitschabaude committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    3e533a7 View commit details
    Browse the repository at this point in the history

  9. add failing unit test

    @mitschabaude
    mitschabaude committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    d69c73a View commit details
    Browse the repository at this point in the history

  10. move smart contract context and start account update layout class

    @mitschabaude
    mitschabaude committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    118cc06 View commit details
    Browse the repository at this point in the history

  11. move some of it back

    @mitschabaude
    mitschabaude committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    2bb10ac View commit details
    Browse the repository at this point in the history

  12. minor

    @mitschabaude
    mitschabaude committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    996be22 View commit details
    Browse the repository at this point in the history

  13. develop account update layout enough to fix unit test

    @mitschabaude
    mitschabaude committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    d2dd5fe View commit details
    Browse the repository at this point in the history

  14. continue expanding account update layout

    @mitschabaude
    mitschabaude committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    c8d439a View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. fixup set children

    @mitschabaude
    mitschabaude committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    5e2b756 View commit details
    Browse the repository at this point in the history

  2. change name to avoid clash with ts keywored

    @mitschabaude
    mitschabaude committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    ef4b154 View commit details
    Browse the repository at this point in the history

  3. introduce siblings to be able to disattach

    @mitschabaude
    mitschabaude committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    599caca View commit details
    Browse the repository at this point in the history

  4. override instanceof? seriously? have I become a hard-core OO progra… 

    …mmer now who will bend over backwards just to use OO idioms?
    @mitschabaude
    mitschabaude committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    43a34d5 View commit details
    Browse the repository at this point in the history

  5. write to au layout in zkapp calls

    @mitschabaude
    mitschabaude committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    54f596f View commit details
    Browse the repository at this point in the history

  6. get from layout in token contract

    @mitschabaude
    mitschabaude committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    71a4200 View commit details
    Browse the repository at this point in the history

  7. disattach from layout in unlink

    @mitschabaude
    mitschabaude committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    4c71d09 View commit details
    Browse the repository at this point in the history

  8. remove selfCalls

    @mitschabaude
    mitschabaude committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    6b6b643 View commit details
    Browse the repository at this point in the history

  9. finalize layout

    @mitschabaude
    mitschabaude committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    3884e6e View commit details
    Browse the repository at this point in the history

  10. don't store variables in aux data

    @mitschabaude
    mitschabaude committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    1ae3d64 View commit details
    Browse the repository at this point in the history

  11. use layout to process zkapp calls

    @mitschabaude
    mitschabaude committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    f68dfcf View commit details
    Browse the repository at this point in the history

  12. fix token test (don't use create child account update)

    @mitschabaude
    mitschabaude committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    3778fa2 View commit details
    Browse the repository at this point in the history

  13. dump vks

    @mitschabaude
    mitschabaude committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    756ade0 View commit details
    Browse the repository at this point in the history

  14. [no children} fromFlatArray which doesn't rely on account update nesting

    @mitschabaude
    mitschabaude committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    1928e17 View commit details
    Browse the repository at this point in the history

  15. minor fix

    @mitschabaude
    mitschabaude committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    0f917b1 View commit details
    Browse the repository at this point in the history

  16. introduce (not yet used) layout for Mina.transaction

    @mitschabaude
    mitschabaude committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    d5ec3fb View commit details
    Browse the repository at this point in the history

  17. match transaction.accountUpdates everywhere

    @mitschabaude
    mitschabaude committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    f3e9169 View commit details
    Browse the repository at this point in the history

  18. throw error if layout doesn't match list length

    @mitschabaude
    mitschabaude committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    f43dc3d View commit details
    Browse the repository at this point in the history

  19. remove nested account updates from tx context

    @mitschabaude
    mitschabaude committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    6da02d7 View commit details
    Browse the repository at this point in the history

  20. put back some code that was premature to remove

    @mitschabaude
    mitschabaude committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    5c138ee View commit details
    Browse the repository at this point in the history

  21. [no children] remove unnecessary logic in token contract

    @mitschabaude
    mitschabaude committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    f96e6a9 View commit details
    Browse the repository at this point in the history

  22. implement to public input w/o children

    @mitschabaude
    mitschabaude committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    030646e View commit details
    Browse the repository at this point in the history

  23. [no children] refactor recursive diff

    @mitschabaude
    mitschabaude committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    09922c0 View commit details
    Browse the repository at this point in the history

  24. remove AccountUpdate.children

    @mitschabaude
    mitschabaude committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    1cbaa48 View commit details
    Browse the repository at this point in the history

  25. some cleanup

    @mitschabaude
    mitschabaude committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    e3a66d6 View commit details
    Browse the repository at this point in the history

  26. remove obsolete method

    @mitschabaude
    mitschabaude committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    bfa8fc9 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. make unfinished tree a class

    @mitschabaude
    mitschabaude committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    202116e View commit details
    Browse the repository at this point in the history

  2. move smart contract context

    @mitschabaude
    mitschabaude committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    a551369 View commit details
    Browse the repository at this point in the history

  3. finish moving smart contract context

    @mitschabaude
    mitschabaude committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    a4c2216 View commit details
    Browse the repository at this point in the history

  4. play with ensuring invariants more strongly

    @mitschabaude
    mitschabaude committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    70302c8 View commit details
    Browse the repository at this point in the history

  5. rename calls to children

    @mitschabaude
    mitschabaude committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    ef9c18c View commit details
    Browse the repository at this point in the history

  6. start refactoring unfinished forest

    @mitschabaude
    mitschabaude committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    c03554b View commit details
    Browse the repository at this point in the history

  7. reorder stuff

    @mitschabaude
    mitschabaude committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    f48955a View commit details
    Browse the repository at this point in the history

  8. tweak remove

    @mitschabaude
    mitschabaude committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    b7a74c4 View commit details
    Browse the repository at this point in the history

  9. better set children logic

    @mitschabaude
    mitschabaude committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    cbc774c View commit details
    Browse the repository at this point in the history

  10. completely get rid of unconstrained array after finalizing

    @mitschabaude
    mitschabaude committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    c4b016a View commit details
    Browse the repository at this point in the history

  11. cleanup, rename

    @mitschabaude
    mitschabaude committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    1e6278e View commit details
    Browse the repository at this point in the history

  12. extract tree

    @mitschabaude
    mitschabaude committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    ed0423b View commit details
    Browse the repository at this point in the history

  13. minor

    @mitschabaude
    mitschabaude committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    acbb260 View commit details
    Browse the repository at this point in the history

  14. not sure if this is a good idea yet

    @mitschabaude
    mitschabaude committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    d437c7e View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. refactor unfinished tree similarly

    @mitschabaude
    mitschabaude committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    fa935cc View commit details
    Browse the repository at this point in the history

  2. fix account update create signed outside tx

    @mitschabaude
    mitschabaude committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    44bf6c9 View commit details
    Browse the repository at this point in the history

  3. another test case for token contract

    @mitschabaude
    mitschabaude committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    0570bfb View commit details
    Browse the repository at this point in the history

  4. approve a whole tree

    @mitschabaude
    mitschabaude committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    e62be7e View commit details
    Browse the repository at this point in the history

  5. proper type for packed/hashed.provable

    @mitschabaude
    mitschabaude committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    ddde1de View commit details
    Browse the repository at this point in the history

  6. struct how it should be

    @mitschabaude
    mitschabaude committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    fe85eb0 View commit details
    Browse the repository at this point in the history

  7. make account update tree a usable class

    @mitschabaude
    mitschabaude committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    e12edc7 View commit details
    Browse the repository at this point in the history

  8. allow approving forests and some other polish

    @mitschabaude
    mitschabaude committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    24f9fb7 View commit details
    Browse the repository at this point in the history

  9. calls -> children

    @mitschabaude
    mitschabaude committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    adc23a2 View commit details
    Browse the repository at this point in the history

  10. more explicit name for globally accessible accout update layout

    @mitschabaude
    mitschabaude committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    314ab5f View commit details
    Browse the repository at this point in the history

  11. remove unnecessary changes

    @mitschabaude
    mitschabaude committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    e4a8729 View commit details
    Browse the repository at this point in the history

  12. some code organization

    @mitschabaude
    mitschabaude committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    aa37ee0 View commit details
    Browse the repository at this point in the history

  13. fixup examples build

    @mitschabaude
    mitschabaude committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    694897d View commit details
    Browse the repository at this point in the history

  14. changelog

    @mitschabaude
    mitschabaude committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    1cb30fa View commit details
    Browse the repository at this point in the history

  15. Merge branch 'main' into refactor/account-update-trees

    @mitschabaude
    mitschabaude committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    5e9e3fd View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. bump live tests timeout

    @mitschabaude
    mitschabaude committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    24475dd View commit details
    Browse the repository at this point in the history