Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix smart contracts not verifying proofs #1302

Merged
merged 14 commits into from
Dec 11, 2023
Merged

Fix smart contracts not verifying proofs #1302

merged 14 commits into from
Dec 11, 2023

Commits on Dec 11, 2023

  1. reproduce bug

    @mitschabaude
    mitschabaude committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    884dcff View commit details
    Browse the repository at this point in the history

  2. can't reproduce with zkprogram!

    @mitschabaude
    mitschabaude committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    b02a695 View commit details
    Browse the repository at this point in the history

  3. make reproduction a proper test

    @mitschabaude
    mitschabaude committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    4b01adc View commit details
    Browse the repository at this point in the history

  4. fix: don't clone proofs so they can be mutated

    @mitschabaude
    mitschabaude committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    c694915 View commit details
    Browse the repository at this point in the history

  5. tweak test some more

    @mitschabaude
    mitschabaude committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    fa71307 View commit details
    Browse the repository at this point in the history

  6. move example to test folder and add more test cases

    @mitschabaude
    mitschabaude committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    5efd814 View commit details
    Browse the repository at this point in the history

  7. add to integration tests

    @mitschabaude
    mitschabaude committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    a43bd3c View commit details
    Browse the repository at this point in the history

  8. minor correction

    @mitschabaude
    mitschabaude committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    e2cf699 View commit details
    Browse the repository at this point in the history

  9. fixup

    @mitschabaude
    mitschabaude committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    44c0024 View commit details
    Browse the repository at this point in the history

  10. change fix to avoid import cycle

    @mitschabaude
    mitschabaude committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    23edcf0 View commit details
    Browse the repository at this point in the history

  11. address feedback and remove unreachable test code

    @mitschabaude
    mitschabaude committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    4b96d79 View commit details
    Browse the repository at this point in the history

  12. reuse some helper types

    @mitschabaude
    mitschabaude committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    37d8719 View commit details
    Browse the repository at this point in the history

  13. add unit test

    @mitschabaude
    mitschabaude committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    13e3c97 View commit details
    Browse the repository at this point in the history

  14. changelog

    @mitschabaude
    mitschabaude committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    515b1c0 View commit details
    Browse the repository at this point in the history