Updated assert* to require* for rest pending precondition apis. #1247 #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Added test cases for verification
|
Could you add some lines to the changelog? under the same bullet point you already started? |
|
Yes sure, Let me add it in sometime. 🙌 |
|
Hi @mitschabaude , Added in the bullet points in Changelog file. Thank You 😃 |
mitschabaude
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mitschabaude ,
Creating this pull request for pending updates in precondition.ts and for the test file.
Can you please help to review and let me know if any changes are required ?
The test cases are passing : #1247 (comment)
Thank You 😃