Make tx.wait() more reliable by increasing block length check to default of 20 blocks
#1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinMinkov
force-pushed
the
feat/fix-network-wait
branch
from
d124c8e
to
ec4ff81
Compare
mitschabaude
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Nice @MartinMinkov, I really appreciate that you're looking after the zkApp DX aspects of o1js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This update introduces improvements to
tx.wait(), addressing reliability issues in transaction inclusion checking within blocks. It includes a fix by checking for the last 20 blocks of a transaction inclusion instead of 1. Additionally, the number of blocks to check forfetchLatestBlockZkappStatusis now customizable.