Fix SnarkyJS to be compatible with new Berkeley #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use logger.fake
…elds Remove duplicate user command fields
Adapt global slot serializations
Fix Wasm build BERKELEY
[berkeley] Make CI run pull requests against `develop`
Merge main into berkeley
mitschabaude
requested changes
Jul 10, 2023
…orators" This reverts commit c37c459.
Trivo25
reviewed
Jul 10, 2023
| "methods": { | ||
| "voterRegistration": { | ||
| "rows": 1259, | ||
| "digest": "252726e585fdd28607537e32214069ab" | ||
| "rows": 1260, |
There was a problem hiding this comment.
that's interesting, I wonder where that extra constraint comes from 🤔
There was a problem hiding this comment.
One more constant that wasn't used before takes one half generic gate!
|
Two more small change requests:
|
…mmyVerificationKey() with mocks.dummyVerificationKeyHash
…sion of snarkyjs signature.ts
…details This commit updates the unreleased changes link and adds the details of version 0.12.0. The breaking changes in version 0.12.0 are also documented, specifically the fix to the default verification key hash for AccountUpdates. This change adopts the default mechanism provided by Mina Protocol and may affect the verification key of already deployed contracts.
…to inclusion of snarkyjs signature.ts" This reverts commit 4bc172d.
…ks from constants.js
…s.dummyVerificationKeyHash for simplicity and readability
…ecoratorMetadata, useDefineForClassFields, and strictPropertyInitialization to support decorators and generic constructors in TypeScript
MartinMinkov
commented
Jul 11, 2023
mitschabaude
approved these changes
Jul 11, 2023
Got this fixed, thanks to your comments. Thanks! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merges
berkeleyintomainNotable Changes
Because the Out-Of-Snark dummy verification key hash changed in this PR, the old verification key hash defaults we used (
Field(0)) were incorrect. There are several places where this value is hard-coded, so we change each place to use the new dummy value. All changes are contained in this commit: 9b4805dUpdate the vk regression tests by creating a new dump.
🔗 Accompanying Bindings PR o1-labs/o1js-bindings#80