Clean up previous proof arguments handling in Pickles/SnarkyJS #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mitschabaude
commented
May 5, 2023
Comment on lines
-2037
to
-2040
| (* TODO: Push this down into SnarkyJS so that it controls the | ||
| public inputs of prev proofs, and we can delete this | ||
| annoying logic. | ||
| *) |
There was a problem hiding this comment.
this TODO is resolved now
Trivo25
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this simplifies the Pickles bindings by handling the public inputs and outputs of proofs on the JS side, instead of in OCaml -- consistent with how other private inputs are handled