expose snarky hashToGroup #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitschabaude
reviewed
May 3, 2023
There was a problem hiding this comment.
Nice work @Trivo25! I have a couple of comments.
In addition to those, I think this should have a unit test which demonstrates that the TS implementation equals the OCaml one.
You can find similar thngs being done in other unit tests like mina-signer/src/signature.unit-test.ts.
Instead of hard-coded test inputs, it's best to use random field elements with our property testing framework, like here in the finite field unit test:
https://github.com/o1-labs/snarkyjs-bindings/blob/290d7b8fbcdc7ecba2f8981811ee958800bc4ad5/crypto/finite-field.unit-test.ts#L26-L27
mitschabaude
approved these changes
May 3, 2023
Co-authored-by: Gregor Mitscha-Baude <gregor.mitscha-baude@gmx.at>
rbonichon
approved these changes
May 3, 2023
Comment on lines
+1160
to
+1162
| let input = Array.map (Js.to_array xs) ~f:of_js_field in | ||
| if Js.to_bool is_checked then Random_oracle.Checked.hash input | ||
| else Random_oracle.hash (Array.map ~f:to_unchecked input) |> Field.constant |
There was a problem hiding this comment.
Suggested change
| let input = Array.map (Js.to_array xs) ~f:of_js_field in | |
| if Js.to_bool is_checked then Random_oracle.Checked.hash input | |
| else Random_oracle.hash (Array.map ~f:to_unchecked input) |> Field.constant | |
| let a = Js.to_array xs in | |
| if Js.to_bool is_checked then Random_oracle.Checked.hash (Array.map a ~f:of_js_field) | |
| else Random_oracle.hash (Array.map a ~f:(fun x -> to_unchecked (of_js_field x)) |> Field.constant |
One fewer iteration in the else case. Don't know if worth it ;-)
Comment on lines
1175
to
+1182
| let digest = | ||
| if Js.to_bool is_checked then Random_oracle.Checked.hash input | ||
| if Js.to_bool is_checked then | ||
| Snark_params.Group_map.Checked.to_group input | ||
| else | ||
| Random_oracle.hash (Array.map ~f:to_unchecked input) |> Field.constant | ||
| let x, y = Snark_params.Group_map.to_group (to_unchecked input) in | ||
| (Field.constant @@ x, Field.constant @@ y) | ||
| in | ||
| to_js_field digest | ||
| to_js_group (fst digest) (snd digest) |
There was a problem hiding this comment.
if Js.to_bool is_checked then Snark_params.Group_map.Checked.to_group input
else
let x, y = Snark_params.Group_map.to_group (to_unchecked input) in
to_js_group (Field.constant x) (Field.constant y)
- the
@@is unneeded - don't need to construct
digestto immediately destruct it throughfstandsnd
This reverts commit bd61c15.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: the params needed for the curve operation are currently hard-coded (originally taken from OCaml) and not calculated in JS
TODO: push bindings
closes o1-labs/o1js#772 companion of o1-labs/o1js#887