-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webpack): provide global URL
and URLSearchParams
#6864
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #6864 +/- ##
==========================================
- Coverage 64.75% 64.69% -0.06%
==========================================
Files 78 78
Lines 2721 2725 +4
Branches 708 709 +1
==========================================
+ Hits 1762 1763 +1
- Misses 730 732 +2
- Partials 229 230 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As ProvidePlugin can be easily configured by build.extend, should we provide this special config only for URL polyfill?
Is there a trick to having this work? I have a universal app that under v2.11.0 I was able to get URL working in client and SSR by setting Updating to 2.12.0 results in |
@dhritzkiv ProvidePlugin is a webpack feature and indeed yes the reason is runInNewContext is enabled by default in dev mode. How sad it broke your project :( Would you please help reproducing in a simple repo to quickly investigate? |
Types of changes
Description
Fixes #4914 by using built-in url package. Tested against node 8.x too. If we want even more consistency, can switch to https://www.npmjs.com/package/whatwg-url.
Related PRs: vuejs/vue#10414.
Checklist: