Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): add catch statement to non function block in serializeFunction (#6776) #6777

Merged
merged 1 commit into from
Dec 16, 2019
Merged

fix(utils): add catch statement to non function block in serializeFunction (#6776) #6777

merged 1 commit into from
Dec 16, 2019

Conversation

crutch12
Copy link

@crutch12 crutch12 commented Dec 10, 2019

fix(vue-app): add catch statement to non function block in serializeFunction (#6776)

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves: #6776

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@crutch12 crutch12 changed the title fix(vue-app): add catch statement to non function block getLocation fix(vue-app): add catch statement to non function block in serializeFunction (#6776) Dec 10, 2019
@codecov-io
Copy link

Codecov Report

Merging #6777 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #6777   +/-   ##
=======================================
  Coverage   64.82%   64.82%           
=======================================
  Files          78       78           
  Lines        2718     2718           
  Branches      706      706           
=======================================
  Hits         1762     1762           
  Misses        729      729           
  Partials      227      227
Flag Coverage Δ
#e2e 100% <ø> (?)
#unit 64.82% <100%> (ø) ⬆️
Impacted Files Coverage Δ
packages/utils/src/serialize.js 89.28% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 112d836...70264a8. Read the comment docs.

@atinux
Copy link
Member

atinux commented Dec 13, 2019

Sounds good to me, will have to look at the failing test 🧐

@pi0 pi0 changed the title fix(vue-app): add catch statement to non function block in serializeFunction (#6776) fix(utils): add catch statement to non function block in serializeFunction (#6776) Dec 16, 2019
@pi0 pi0 merged commit b2a35d2 into nuxt:dev Dec 16, 2019
@pi0 pi0 mentioned this pull request Dec 17, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

serializeFunction detectes catch statements as functions
5 participants