Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-app): layout in error.vue not work for Vue.extend component #6650

Merged
merged 3 commits into from
Nov 5, 2019

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Nov 3, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Description

Fix #6651
Reported from Discord from @aldarund , when component is from Vue.extend, the layout on error.vue doesn't, this is because layout is component.options.layout but not component.layout.

Checklist:

  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested review from aldarund, kevinmarrec and a team November 3, 2019 16:34
@clarkdo clarkdo changed the title fix: layout in error.vue not work for Vue.extend component fix(vue-app): layout in error.vue not work for Vue.extend component Nov 3, 2019
@clarkdo clarkdo requested a review from a team November 5, 2019 10:52
@codecov-io
Copy link

codecov-io commented Nov 5, 2019

Codecov Report

Merging #6650 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #6650   +/-   ##
=======================================
  Coverage   95.79%   95.79%           
=======================================
  Files          78       78           
  Lines        2713     2713           
  Branches      702      702           
=======================================
  Hits         2599     2599           
  Misses         99       99           
  Partials       15       15
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 64.65% <ø> (ø) ⬆️
#unit 92.29% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3948e60...efb9af7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: error layout not applied properly when error isnt plain object
6 participants