Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error handling experience for nuxi module add when install fails #131

Closed
atinux opened this issue Aug 31, 2023 — with Volta.net · 2 comments · Fixed by #208
Closed

improve error handling experience for nuxi module add when install fails #131

atinux opened this issue Aug 31, 2023 — with Volta.net · 2 comments · Fixed by #208
Labels
discussion enhancement New feature or request

Comments

Copy link
Member

atinux commented Aug 31, 2023

Example of installing an npm package that does not exist:
CleanShot 2023-08-31 at 11.57.49@2x.png

@atinux atinux added bug Something isn't working good first issue Good for newcomers labels Aug 31, 2023 — with Volta.net
@pi0 pi0 added enhancement New feature or request discussion and removed bug Something isn't working good first issue Good for newcomers labels Aug 31, 2023
@pi0
Copy link
Member

pi0 commented Aug 31, 2023

It would be nice to indeed improve the error handling but there might be other reasons (such as network error or private packages or package manager fault) that packages cannot be installed. I suggest to instead, use a confirmation prompt either continuing the addition to the config or cancel operation when install is failing.

@pi0 pi0 changed the title [module add] Quit the process if cannot install the dependency improve error handling experience for nuxi module add when install fails Aug 31, 2023
@pi0
Copy link
Member

pi0 commented Aug 31, 2023

Also likning unjs/nypm#89, i am thinking when package manager cannot be detected, to also make nypm behavior more "gentle" and only update package.json (using manual npm resolution to make sure package is still valid)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants