Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow assets to be made public / private #3177

Open
sync-by-unito bot opened this issue Jan 15, 2024 · 10 comments
Open

allow assets to be made public / private #3177

sync-by-unito bot opened this issue Jan 15, 2024 · 10 comments
Assignees

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Jan 15, 2024

allow dashboard to set assets as either public or private

┆Issue is synchronized with this Asana task by Unito
┆Created By: Ethan Wu

Copy link
Author

sync-by-unito bot commented Jan 15, 2024

➤ Ethan Wu commented:

where do we want to put this feature? my initial thoughts are to put it in the edit window.

what are your thoughts Kenny Hung?

also when assets are made public or made private does it consume NUM to do this?

Copy link
Author

sync-by-unito bot commented Jan 15, 2024

➤ Sherry Chung commented:

I think Edit window is a good choice.

For setting public or not, will it also update the assettree and adding a commit for the change? If there is an additional commit in mainnet, than it'll consume NUM

cc Tammy Yang

Copy link
Author

sync-by-unito bot commented Jan 15, 2024

➤ Kenny Hung commented:

Ethan WuTammy Yang For this task, my proposal is

add a toggle on asset detail page. How do you think?

image.pngText: Enable Public Accessibility for Asset

description: Once enabled, anyone with the asset's Nid can easily locate and view it.

Copy link
Author

sync-by-unito bot commented Jan 15, 2024

➤ Sherry Chung commented:

Kenny HungEthan Wu I won’t suggest to put a toggle under asset detail.

This section if for “information showing”. Not for “action taken”

If we have 2 “action taken” in 2 different place. One in top right corner for “Publish”, another under the detail information. As I know it’s not a good UX design.

And the toggle also can’t fix in one place if we put this under detail page. Because user will expand the detail information. This also cause the distraction in UX

Copy link
Author

sync-by-unito bot commented Jan 15, 2024

➤ Sherry Chung commented:

I would suggest we think this from user’ behavior. When will user want to set the assets to public/private. Is it one-time change or we allow user to change this many times?

And where do we have similar “action taken” step for users

I’m thinking put this under either “Edit” function or “Publish” action.

We can discuss which make more sense.

Copy link
Author

sync-by-unito bot commented Jan 15, 2024

➤ Kenny Hung commented:

Sherry Chung (cc Ethan Wu)

I think it's feasible to include this feature in either the edit function or publish drop list. My question is, what form should this feature take in these areas? Do you have a recommended approach?

Copy link
Author

sync-by-unito bot commented Jan 15, 2024

➤ Sherry Chung commented:

Ethan WuKenny Hung I have some thought. Let’s also move this to next sprint. I’ll purpose the flow first (cc Tammy Yang )

Copy link
Author

sync-by-unito bot commented Jan 15, 2024

➤ Ethan Wu commented:

Sherry Chung when oyu have time can you please share your thoughts on this? thanks!

Copy link
Author

sync-by-unito bot commented Jan 15, 2024

➤ Sherry Chung commented:

Ethan WuKenny Hung I 've made some suggestion on subtask. However, since we'll have some scenario need to clarify.

I would suggest we also skip this FR in current sprint. I'll work with Tammy Yang to finalize it.

Copy link
Author

sync-by-unito bot commented Jan 15, 2024

➤ Sherry Chung commented:

Focus on presidential election & end-to-end flow for sprint 24-01-01. I'll move this to next sprint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant