Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consumer: retry nsqlookupd query if it fails #97

Closed
mnutt opened this issue Nov 23, 2014 · 2 comments · Fixed by #209
Closed

consumer: retry nsqlookupd query if it fails #97

mnutt opened this issue Nov 23, 2014 · 2 comments · Fixed by #209

Comments

@mnutt
Copy link

mnutt commented Nov 23, 2014

A few days ago, due to a provisioning error, I accidentally added a bad lookupd to the list. My app eventually queried a working lookupd and began processing messages, but it took about a minute. (which is what the poll interval is set to) I know there is a balance between finding new nodes and not overloading the lookupds, but would it make sense to try all of the lookupds on startup until one returned success? I'm happy to submit a pull request if that's the case.

@mreiferson
Copy link
Member

Hi @mnutt - that sounds like a reasonable change to make for every iteration... if a configured nsqlookupd errors try the next one immediately.

@mreiferson mreiferson changed the title Hanging on non-existent lookupds retry nsqlookupd query if it fails Jan 12, 2015
@mreiferson mreiferson changed the title retry nsqlookupd query if it fails consumer: retry nsqlookupd query if it fails Jul 15, 2015
@mreiferson
Copy link
Member

see #209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants