makeSureNoAppIsSelected is inaccurate for ng test -a app-name

[emilio-martinez]

makeSureNoAppIsSelected() correctly verifies passed arguments as long as they're formulated as -a=app-name or --app=app-name. However, arguments are missed if they're formulated without the equal sign after the argument key, i.e., -a app-name or --app app-name.

That syntax, both with and without the equals sign after the argument key, is valid, as shown in Angular CLI's "Multiple Apps integration" story.

See reference below to where the equal sign is being explicitly sought out as part of the argument.

nx/packages/schematics/src/utils/cli-config-utils.ts

Lines 25 to 43 in be6bfd3

	export function makeSureNoAppIsSelected() {
	if (findAppArg()) {
	console.error('Nx only supports running unit tests for all apps and libs.');
	console.error('You cannot use -a or --app.');
	console.error('Use fdescribe or fit to select a subset of tests to run.');
	process.exit(1);
	}
	}
	function findAppArg() {
	return process.argv.filter(
	a =>
	a.startsWith(`-a=`) ||
	a.startsWith(`--app=`) ||
	a.startsWith(`"-a="`) ||
	a.startsWith(`"--app="`) ||
	a.startsWith(`'-a='`) ||
	a.startsWith(`'--app='`)
	)[0];

[FrozenPandaz]

I can take this

[FrozenPandaz]

This should no longer be an issue as of 0.10.0.

[github-actions]

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.