From da01ca3dac381a11c8fa5935f28386bb796ebd4a Mon Sep 17 00:00:00 2001
From: Thilina Rathnayake <thilinarmtb@gmail.com>
Date: Wed, 4 Oct 2023 11:29:28 -0400
Subject: [PATCH] Fix the remaining warnings in hip backend

---
 backends/unified-cuda-hip-impl.h | 8 ++++----
 include/nomp-impl.h              | 6 ++++++
 src/loopy.c                      | 1 +
 3 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/backends/unified-cuda-hip-impl.h b/backends/unified-cuda-hip-impl.h
index 28ad08b8..076dde98 100644
--- a/backends/unified-cuda-hip-impl.h
+++ b/backends/unified-cuda-hip-impl.h
@@ -76,7 +76,7 @@ static backendrtcResult backend_compile(backendrtcProgram prog,
   return backendrtcCompileProgram(prog, 1, opts);
 }
 
-static int backend_update(nomp_backend_t *bnd, nomp_mem_t *m,
+static int backend_update(nomp_backend_t *NOMP_UNUSED(bnd), nomp_mem_t *m,
                           const nomp_map_direction_t op, size_t start,
                           size_t end, size_t usize) {
   if (op & NOMP_ALLOC)
@@ -142,7 +142,7 @@ static int backend_knl_build(nomp_backend_t *bnd, nomp_prog_t *prg,
   return 0;
 }
 
-static int backend_knl_run(nomp_backend_t *bnd, nomp_prog_t *prg) {
+static int backend_knl_run(nomp_backend_t *NOMP_UNUSED(bnd), nomp_prog_t *prg) {
   nomp_arg_t *args = prg->args;
   void *vargs[NOMP_MAX_KERNEL_ARGS_SIZE];
   for (unsigned i = 0; i < prg->nargs; i++) {
@@ -168,7 +168,7 @@ static int backend_knl_free(nomp_prog_t *prg) {
   return 0;
 }
 
-static int backend_sync(nomp_backend_t *bnd) {
+static int backend_sync(nomp_backend_t *NOMP_UNUSED(bnd)) {
   check_driver(backendDeviceSynchronize());
   return 0;
 }
@@ -219,7 +219,7 @@ static int backend_device_query(nomp_backend_t *bnd, int device) {
 }
 
 #define backend_init TOKEN_PASTE(DRIVER, _init)
-int backend_init(nomp_backend_t *const backend, const int platform,
+int backend_init(nomp_backend_t *const backend, const int NOMP_UNUSED(platform),
                  const int device) {
   int num_devices;
   check_driver(backendGetDeviceCount(&num_devices));
diff --git a/include/nomp-impl.h b/include/nomp-impl.h
index 2a18ec61..65e976a8 100644
--- a/include/nomp-impl.h
+++ b/include/nomp-impl.h
@@ -256,6 +256,12 @@ typedef struct nomp_backend nomp_backend_t;
 extern "C" {
 #endif
 
+#ifdef __GNUC__
+#define NOMP_UNUSED(x) NOMP_UNUSED_##x __attribute__((__unused__))
+#else
+#define NOMP_UNUSED(x) NOMP_UNUSED_##x
+#endif
+
 /**
  * @defgroup nomp_internal_macros Internal macros
  * @brief Internal macros used in libnomp.
diff --git a/src/loopy.c b/src/loopy.c
index 4f75be4c..d143da88 100644
--- a/src/loopy.c
+++ b/src/loopy.c
@@ -39,6 +39,7 @@ void nomp_py_print(const char *const message, PyObject *const obj) {
  */
 int nomp_py_init(const nomp_config_t *const cfg) {
   strncpy(backend, cfg->backend, NOMP_MAX_BUFFER_SIZE);
+  backend[NOMP_MAX_BUFFER_SIZE] = '\0';
 
   if (!Py_IsInitialized()) {
     // May be we need the isolated configuration listed here: