Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have you heard about this issue? #177

Closed
zhangtreefish opened this issue Oct 24, 2016 · 3 comments
Closed

Have you heard about this issue? #177

zhangtreefish opened this issue Oct 24, 2016 · 3 comments

Comments

@zhangtreefish
Copy link

zhangtreefish commented Oct 24, 2016

Marcel,
I am not sure whether the issue is with nodist or not, but it is this. I have been contributing to a React project, and recently have problem starting the app; the other contributors were mostly able to solve similar problems by reinstalling node, except one other developer who had Windows and who uses nvm also has problem starting the app with the same error message about webpack-dev-server (please see the error log in the link). Any advice would be greatly appreciated.

@marcelklehr
Copy link
Member

marcelklehr commented Oct 24, 2016

This is the first I hear about this issue and I'd say it's unlikely this is related to nodist. I noticed, you've added C:\Program Files (x86)\Nodist\v-x64\5.2.0 directly to the PATH, which is not part of the installation instructions. What was the reason for that?

@zhangtreefish
Copy link
Author

zhangtreefish commented Oct 24, 2016

Upon installation of Nodist the PATH of system environmental variable automatically includes this: C:\Program Files (x86)\Nodist\bin, not :\Program Files (x86)\Nodist\v-x64\5.2.0.

In addition, I can see that system environmental variables also include NODE_PATH and NODIST_PREFIX. Here is a screen shot:
image

Not sure if I have used Nodist correctly, I am listing what I did hoping anyone can catch some mistake: removing node and npm path entries including C:\Users\username\AppData\Roaming\npm; installing following the wizard;

nodist + 5.2.0
nodist global 5.2.0
nodist env 5.2.0
nodist local 5.2.0

(since my app requires npm 3.10.7):

nodist npm global 3.10.7
nodist npm env 3.10.7
nodist npm local 3.10.7

At this point, after I enter nodist, I get this:

  (x64)
> 5.2.0  (env: 5.2.0) (C:\Users\Treefish\alumni-client\.node-version: 5.2.0) (global: 5.2.0)

And the node and npm look like this:

C:\Users\Treefish\alumni-client>which npm
/cygdrive/c/Program Files (x86)/Nodist/bin/npm

C:\Users\Treefish\alumni-client>which node
/cygdrive/c/Program Files (x86)/Nodist/bin/node

C:\Users\Treefish\alumni-client>where npm
C:\Program Files (x86)\Nodist\bin\npm.cmd
C:\Program Files (x86)\Nodist\bin\npm.exe

C:\Users\Treefish\alumni-client>where node
C:\Program Files (x86)\Nodist\bin\node.exe

Have I used Nodist correctly? Thank you so much.

@marcelklehr
Copy link
Member

marcelklehr commented Oct 29, 2016

sorry for the delay: yes, it appears you have used it correctly. I now realize that this could have to do with a bug that transpired recently: Using node APIs to terminate a node process won't work with nodist, because windows doesn't have the concept of signals. So nodist's binary shim will be terminated, but the node process keeps running. If it's a server (as in your case) it'll block the port it's occupying and re-starting will fail. See #174 #173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants