Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TM1829 module missing in master & dev #920

Closed
marcelstoer opened this issue Jan 11, 2016 · 6 comments
Closed

TM1829 module missing in master & dev #920

marcelstoer opened this issue Jan 11, 2016 · 6 comments

Comments

@marcelstoer
Copy link
Member

Just noticed that #686 is missing in master & dev. I couldn't find any notes as to why this could be intentional. Was it simply forgotten in the recent 1.4 upgrade and the necessary branch/PR clean-up (PR was directly merged to master)?
@jmattsson
Copy link
Member

I'm not aware of any reason why it should be excluded. I'd say it was simply missed in the cleanup.

@TerryE
Copy link
Collaborator

TerryE commented Jan 12, 2016

+1 My bad.

@devsaurus
Copy link
Member

Thought it was still awaiting some kind of check/verification since it never got in touch with a recent SDK on dev.

@TerryE
Copy link
Collaborator

TerryE commented Jan 12, 2016

Yup, I did ask the contributors to resubmit, but I should have followed it up.

@marcelstoer
Copy link
Member Author

@h3ndrik can you please take care of that.

This was referenced Jan 28, 2016
Closed
Closed
@h3ndrik
Copy link

h3ndrik commented Jan 28, 2016

thanks. submitted new pull requests for master #983 and dev-branch #984

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@h3ndrik @marcelstoer @TerryE @jmattsson @devsaurus