enduser_setup not working

[HHHartmann]

Expected behavior

the POST /setwifi call shpould parse the params

Actual behavior

1. The end of the wifi_password param is searched to be & or space. In the post it is not anymore but the end of the message
2. if the headers and body are fragmented in several packets only the first one is analyzed and thus data is incomplete. This applies to the GET request as well but likely will nerver hit there.
   At least fiddler (a windows web analyzer tool) does send headers and body in two packets.

(1.) works well on params in the URL as used in the GET request. They are terminated by '&' or 'space'

GET /url?wifi_ssid=ssid&wifi_password=pass HTTP/1.1

The new POST locks loke this:

POST http://aaa.com/setwifi HTTP/1.1
Host: aaa.com
Content-Type: application/x-www-form-urlencoded
Accept-Encoding: gzip, deflate
Content-Length: 30

wifi_ssid=xxx&wifi_password=aa

So the wifi_password is terminated by the end of data here.

Test code

compile with

#define ENDUSER_SETUP_DEBUG_ENABLE 1
#define ENDUSER_SETUP_DEBUG_SHOW_HTTP_REQUEST 1

Example from the documentation

enduser_setup.start(
  function()
    print("Connected to WiFi as:" .. wifi.sta.getip())
  end,
  function(err, str)
    print("enduser_setup: Err #" .. err .. ": " .. str)
  end,
  print -- Lua print function can serve as the debug callback
)

NodeMCU version

Current dev build with the brand new enduser_setup

Hardware

ESP8266 dev board

[d-rez]

Looking at source this is by design as the code is only handling GET:

https://github.com/nodemcu/nodemcu-firmware/blob/master/app/modules/enduser_setup.c#L947

EDIT: Nevermind, wrong branch

[HHHartmann]

Have a look on dev. It's a new design now.

[HHHartmann]

Will fix 1. but the fragmentation part is above my C skills.

[marcelstoer]

Interesting. Looks like my browser didn't fragment the packets then.

[HHHartmann]

The missing part of this bug is covered in detail in #2931. So closing this issue