-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input on coverage.nodejs.org #1019
Comments
@mhdawson This looks cool! I noticed that the coverage links currently go to 404. Known issue?
If you need any help on this just let me know. Good job! |
Is there an existing ingress point to this page from nodejs.org? Seems like a good opportunity. |
@ryanmurakami. This looks cool! I noticed that the coverage links currently go to 404. Known issue?
In terms of helping, if you'd like to submit a PR to make the changes against https://github.com/nodejs/testing/blob/master/coverage/generate-index-html.py that would be great. Currently I don't think we have ingress points from nodejs.org for coverage.nodejs.org or benchmarking.nodejs.org. Would be good to have both of those. |
@mhdawson FYI: UTF-8 characters in the footer of http://coverage.nodejs.org are broken. |
@fhemberger I'll take care of this in my PR |
@mhdawson I'm noticing there are a lot of material design classes, but the CSS isn't included so there aren't styles being applied. Do you want me to strip that out, or add the styles in? Personally, I don't think we need it, but wanted to check with you. |
@mhdawson Here's what I've done. Thoughts? |
@ryanmurakami, PR landed in nodejs/testing to update and looking good so closing this issue. Thanks for the input and the work to submit the change. I'll open a separate issue so that we don't forget about considering an ingress point for the coverage and benchmarking pages. |
Possibly a bit late, but better late than never.
Now that we've added coverage.nodejs.org (as per issue nodejs/testing#36) I'd like to see if the website WG has any comments/suggestions on the layout.
The text was updated successfully, but these errors were encountered: