Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input on coverage.nodejs.org #1019

Closed
mhdawson opened this issue Nov 9, 2016 · 8 comments
Closed

Input on coverage.nodejs.org #1019

mhdawson opened this issue Nov 9, 2016 · 8 comments
Labels
content Issues/pr concerning content

Comments

@mhdawson
Copy link
Member

mhdawson commented Nov 9, 2016

Possibly a bit late, but better late than never.

Now that we've added coverage.nodejs.org (as per issue nodejs/testing#36) I'd like to see if the website WG has any comments/suggestions on the layout.

@mhdawson mhdawson changed the title Input con coverage.nodejs.org Input on coverage.nodejs.org Nov 9, 2016
@mhdawson mhdawson added the content Issues/pr concerning content label Nov 9, 2016
@ryanmurakami
Copy link
Contributor

@mhdawson This looks cool! I noticed that the coverage links currently go to 404. Known issue?
Here are my suggestions:

  • Change "Node.js Core" header to non-link, increase the size, and have the link to the repo beside the title. Perhaps you could use an icon like this.
  • At the title/header level, indicate this is nightly coverage.
  • Format the date/time to make it easier to read. Maybe a format like this: mm/dd/yyyy hh:mm
  • Increase distance between each column, so it's clear where each ends/begins.

If you need any help on this just let me know. Good job!

@ryanmurakami
Copy link
Contributor

Is there an existing ingress point to this page from nodejs.org? Seems like a good opportunity.

@mhdawson
Copy link
Member Author

@ryanmurakami. This looks cool! I noticed that the coverage links currently go to 404. Known issue?

You managed to look just at the wrong time. :) I was integrating a PR which led to a hickup. Should be all ok now.

In terms of helping, if you'd like to submit a PR to make the changes against https://github.com/nodejs/testing/blob/master/coverage/generate-index-html.py that would be great.

Currently I don't think we have ingress points from nodejs.org for coverage.nodejs.org or benchmarking.nodejs.org. Would be good to have both of those.

@fhemberger
Copy link
Contributor

@mhdawson FYI: UTF-8 characters in the footer of http://coverage.nodejs.org are broken.

@ryanmurakami
Copy link
Contributor

@fhemberger I'll take care of this in my PR

@ryanmurakami
Copy link
Contributor

@mhdawson I'm noticing there are a lot of material design classes, but the CSS isn't included so there aren't styles being applied. Do you want me to strip that out, or add the styles in? Personally, I don't think we need it, but wanted to check with you.

@ryanmurakami
Copy link
Contributor

@mhdawson Here's what I've done. Thoughts?

screen shot 2016-11-10 at 2 10 17 pm

@mhdawson
Copy link
Member Author

@ryanmurakami, PR landed in nodejs/testing to update and looking good so closing this issue. Thanks for the input and the work to submit the change. I'll open a separate issue so that we don't forget about considering an ingress point for the coverage and benchmarking pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Issues/pr concerning content
Projects
None yet
Development

No branches or pull requests

3 participants