From ee6e8812ec4ed62b7c58f570c4842354798f2f6f Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Thu, 22 Dec 2022 19:16:38 +0100 Subject: [PATCH 1/3] meta: update comment in `CODEOWNERS` to better reflect current policy We do not enforce signing off by any code owners when landing PRs. --- .github/CODEOWNERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index acacee156126af..e7080a003be048 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -2,8 +2,8 @@ # 1. Codeowners must always be teams, never individuals # 2. Each codeowner team should contain at least one TSC member -# 3. PRs touching any code with a codeowner must be signed off by at least one -# person on the code owner team. +# 3. PRs touching any code with a codeowner must tag said owners and wait for an +# appropriate time to let them time to review the changes. # tsc From 210d7a6d4248bbaf3034702e415be5e66aa22108 Mon Sep 17 00:00:00 2001 From: Geoffrey Booth Date: Wed, 28 Dec 2022 14:56:01 -0800 Subject: [PATCH 2/3] Update .github/CODEOWNERS Co-authored-by: Antoine du Hamel --- .github/CODEOWNERS | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index e7080a003be048..329bc5d8f031dd 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -2,8 +2,11 @@ # 1. Codeowners must always be teams, never individuals # 2. Each codeowner team should contain at least one TSC member -# 3. PRs touching any code with a codeowner must tag said owners and wait for an -# appropriate time to let them time to review the changes. +# 3. This file does not define any requirements for landing PRs. +# Its purpose is to allow automation of courtesy pings to the +# relevant team(s) when any of the paths listed here are modified. +# Criteria for landing PRs are defined in +# https://github.com/nodejs/node/blob/main/doc/contributing/collaborator-guide.md#code-reviews. # tsc From 604c03b5888c360e296ade5e2011d1378e2b001c Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Wed, 28 Dec 2022 23:59:41 +0100 Subject: [PATCH 3/3] Remove the ordered list --- .github/CODEOWNERS | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 329bc5d8f031dd..9ed8d1f7ddbb4f 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,12 +1,12 @@ # Node.js Project Codeowners -# 1. Codeowners must always be teams, never individuals -# 2. Each codeowner team should contain at least one TSC member -# 3. This file does not define any requirements for landing PRs. -# Its purpose is to allow automation of courtesy pings to the -# relevant team(s) when any of the paths listed here are modified. -# Criteria for landing PRs are defined in -# https://github.com/nodejs/node/blob/main/doc/contributing/collaborator-guide.md#code-reviews. +# This file does not define any requirements for landing PRs. +# Its purpose is to allow automation of courtesy pings to the +# relevant team(s) when any of the paths listed here are modified. +# Criteria for landing PRs are defined in +# https://github.com/nodejs/node/blob/main/doc/contributing/collaborator-guide.md#code-reviews. +# +# Codeowners must always be teams, never individuals. # tsc