Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: async-hello-world/binding.cc is missing unistd.h in windows #3531

Closed
john-yan opened this issue Oct 26, 2015 · 1 comment
Closed

test: async-hello-world/binding.cc is missing unistd.h in windows #3531

john-yan opened this issue Oct 26, 2015 · 1 comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Comments

@john-yan
Copy link

async-hello-world/binding.cc is missing unistd.h in windows. Can we use std::this_thread::sleep_for as an alternative?
@john-yan john-yan mentioned this issue Oct 26, 2015
Closed
@Trott Trott added the test Issues and PRs related to the tests. label Oct 26, 2015
@mscdex mscdex added c++ Issues and PRs that require attention from people who are familiar with C++. windows Issues and PRs related to the Windows platform. labels Oct 26, 2015
@bnoordhuis
Copy link
Member

Fixed by 4139f2a. Sorry, didn't see you linked to this issue in PR #3532.

@aliscco aliscco mentioned this issue Feb 11, 2024
Open
@aliscco aliscco mentioned this issue Mar 23, 2024
Open
@aliscco aliscco mentioned this issue May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mscdex @bnoordhuis @Trott @john-yan