Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new label "review wanted"? #27119

Closed
joyeecheung opened this issue Apr 7, 2019 · 4 comments
Closed

A new label "review wanted"? #27119

joyeecheung opened this issue Apr 7, 2019 · 4 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@joyeecheung
Copy link
Member

joyeecheung commented Apr 7, 2019

I think it would be useful to have a "review wanted" label for PRs that are still looking for reviews. "author ready" is not an exact complement to this, since it can also be applied when there is only one review, but sometimes a PR may want more eyeballs before it lands. This may also be helpful for PRs that have gone in and out of progress due to technical issues or PRs that have been stalled for a while if they want some fresh reviews.

@joyeecheung joyeecheung added the meta Issues and PRs related to the general management of the project. label Apr 7, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Apr 7, 2019

Having that label would be great!

@gireeshpunathil
Copy link
Member

great thought! can you please outline the life cycle events of the label? for example anyone including the owner attaches this label when they think this needs one or more reviews? and then detaches when owner or anyone who reviewed decides that the PR got enough reviews?

@joyeecheung
Copy link
Member Author

joyeecheung commented Apr 7, 2019

I guess for most PRs, it goes like: add review wanted -> get approvals -> remove review wanted -> add author ready -> land

For PRs with a longer review cycle: add review wanted -> get reviews (change requests) -> remove review wanted and address reviews -> get approvals -> add author ready -> land.
(Also someone may add author ready early, then some change requests come in, and author ready may be removed until the reviews are addressed.)

For PRs that are trickier, the first review wanted would be add much later than normal PRs, but it helps to signal that this PR is now ready for review.

For PRs that stalled, the review wanted labeled may be added and removed several times during its life time before author ready (if it ever gets there).

@joyeecheung
Copy link
Member Author

OK, I went ahead and created the label review wanted PRs that need reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

No branches or pull requests

3 participants