Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document about CI results expected in the onboarding PR #18835

Closed
joyeecheung opened this issue Feb 17, 2018 · 2 comments
Closed

Document about CI results expected in the onboarding PR #18835

joyeecheung opened this issue Feb 17, 2018 · 2 comments
Labels
doc Issues and PRs related to the documentations.

Comments

@joyeecheung
Copy link
Member

joyeecheung commented Feb 17, 2018 •
edited
Loading

Refs: #18824 (comment)

I believe the current practice is:

  1. Ask the people getting onboard to launch a full CI (to make sure they can do that), and paste the link in the PR
  2. After the linter goes green, stop the CI (since it's just a documentation change we don't really need to get a green full CI, also unfortunately these days the full CI are almost never green..)
  3. We don't require onboarding PR to wait for 48/72 hours, so with at least one LGTM and a green linter , the PR is ready to land. How long the PR needs to wait depends on the author. It's OK to wait for < 30mins, IMO.
@joyeecheung joyeecheung added the doc Issues and PRs related to the documentations. label Feb 17, 2018
@Trott
Copy link
Member

Trott commented Feb 18, 2018

Partially (or completely?) dealt with in #18846

@jasnell
Copy link
Member

jasnell commented Oct 19, 2018

I believe this can be closed now. Please reopen if that's incorrect

@jasnell jasnell closed this as completed Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jasnell @Trott @joyeecheung