Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: deprecate http.ClientRequest 'aborted' event #15469

Closed
ronag opened this issue Sep 19, 2017 · 4 comments
Closed

http: deprecate http.ClientRequest 'aborted' event #15469

ronag opened this issue Sep 19, 2017 · 4 comments
Labels
http Issues or PRs related to the http subsystem.

Comments

@ronag
Copy link
Member

ronag commented Sep 19, 2017 •
edited
Loading

We might consider emitting a ECONNRESET for the response aborted case (just like the request) and then deprecate the aborted event (i.e. remove it from the docs) since it is already achieved through ECONNRESET error events.
@ronag ronag mentioned this issue Sep 19, 2017
Closed
@lpinca
Copy link
Member

lpinca commented Sep 19, 2017 •
edited
Loading

Title is misleading as there is no 'aborted' event on http.ClientRequest, only 'abort'.

@ronag
Copy link
Member Author

ronag commented Sep 19, 2017 •
edited
Loading

@lpinca Yes there is.

https://nodejs.org/api/http.html#http_event_aborted
#15270

@lpinca
Copy link
Member

lpinca commented Sep 19, 2017

Yes, that is wrong as discussed in #15259.
PR to fix the issue: #15471.

@mscdex mscdex added the http Issues or PRs related to the http subsystem. label Sep 19, 2017
@lpinca
Copy link
Member

lpinca commented Sep 29, 2017

Closing as #15471 has been merged.

@lpinca lpinca closed this as completed Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mscdex @lpinca @ronag