-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http2 - compat should not emit aborted on request if has response #15339
Comments
I'm not sure I fully follow, could you elaborate? My understanding of how this currently works:
|
Re: your update, |
This is where the inconsistency is since the compat request and response just forwards the stream |
Sorry, I'm getting confused between incoming message and client requests. |
No worries! I (and I'm sure everyone else) appreciate you looking at h2 in such detail. We need people using it to get it ready for prime-time. |
Per discussion in, #15270.
h2 compat should not emit
aborted
on the request object if the stream has received a response. To make it consistent with h1 behavior.Depending on #15270 we might want to also make h2 compat request emit a
ECONNRESET
onaborted
. To make it consistent with h1 behavior.I'm a little unsure about the
http.ClientRequest
vshttp.IncomingMessage
behavior. Are they the same or different? I'm basing this soley onhttp.ClientRequest
behavior.The text was updated successfully, but these errors were encountered: